search

MorsGames / sm64plus

A fork of sm64-port that focuses on QoL improvements and customizability.
https://mfgg.net/index.php?act=resdb&param=02&c=2&id=38190
453 stars 32 forks source link

Macos fixes #83

Closed sofakng closed 1 year ago

sofakng commented 1 year ago

Here are the fixes required to allow compilation on macOS. Tested on an Apple MacBook M1 Pro running macOS Ventura v13.2.1 with GCC v12.2.0 (via Homebrew).

There is code to work with macports and homebrew but I've only tested homebrew.

This also includes a temporary workaround for silent audio on macOS. I've tried troubleshooting but I can't figure it out. src/pc/audio/audio_sdl2.c uses SDL_MixAudioFormat to adjust the volume based on the configOverallVolume setting. The workaround is to bypass the mixer and volume adjustment (only for macOS).

Saturn345 commented 1 year ago

cool

MorsGames commented 1 year ago

Seems like there are no issues, so I merged it into the dev branch to get included in the next release. Thank you so much for the contribution!

sofakng commented 1 year ago

Great, thanks so much for accepting it!