search

MorseKOB / PyKOB

Python implementation of a library for Morse and MorseKOB functionality
https://sites.google.com/site/morsekob/morsekob40
MIT License
4 stars 2 forks source link

pykob/config depends on Python 3.6 #22

Closed leskerr closed 4 years ago

leskerr commented 4 years ago

Formatted string literals fail with Python 3.5.

AESilky commented 4 years ago

Changed f"{var}" formatted strings to "{}".format(var) to remove the requirement of Python 3.6. This allows pykob to use older version of Python3.

AESilky commented 4 years ago

I didn't have a machine running a lower version of Python3 to test with, but I tested that Configure.py still works and prints information correctly, so I merged into master and will close.

We can reopen if we find that there is still a problem. @leskerr maybe you can test on your Pi that you discovered the issue on.

leskerr commented 4 years ago

I'll try it on my Pi while it's still running Python 3.5. If there's a problem (unlikely) I'll let you know.

~Les

On Fri, May 1, 2020 at 9:42 AM Ed Silky notifications@github.com wrote:

I didn't have a machine running a lower version of Python3 to test with, but I tested that Configure.py still works and prints information correctly, so I merged into master and will close.

We can reopen if we find that there is still a problem. @leskerr https://github.com/leskerr maybe you can test on your Pi that you discovered the issue on.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/MorseKOB/PyKOB/issues/22#issuecomment-622464063, or unsubscribe https://github.com/notifications/unsubscribe-auth/APHISTI42MI3IR6565EPCF3RPL3XHANCNFSM4MW26TYQ .

leskerr commented 4 years ago

Fix remaining f'...' literals.

AESilky commented 4 years ago

I'm curious where you found more? I did a file search of what I had in my project workspace and changed all that it identified. I'll take a look at your changes to see what I missed to try to understand why.

leskerr commented 4 years ago

Did you search for f' as well as f"?

AESilky commented 4 years ago

No, that was my mistake. I had forgotten that I had used any in the form f'.

pwdirks commented 4 years ago

Don’t feel bad - I double-checked to see if I got your fix with a ‘grep -r’ but only looked for f-double-quote as well :-)

On May 1, 2020, at 11:50 PM, Ed Silky notifications@github.com wrote:

No, that was my mistake. I had forgotten that I had used any in the form f'.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/MorseKOB/PyKOB/issues/22#issuecomment-622744263, or unsubscribe https://github.com/notifications/unsubscribe-auth/ALTAYK3T5UCUUZG4DADR5ADRPO7CNANCNFSM4MW26TYQ.

AESilky commented 4 years ago

@leskerr can this be closed?

leskerr commented 4 years ago

Yes, I'm closing it now.