search

MorseKOB / PyKOB

Python implementation of a library for Morse and MorseKOB functionality
https://sites.google.com/site/morsekob/morsekob40
MIT License
4 stars 2 forks source link

Pwd #243: limit to single preferences panel at runtime #244

Closed pwdirks closed 3 years ago

pwdirks commented 3 years ago

Change preferences logic to rely on running Tkinter mainloop() instead of starting a separate one; track preferences window and merely pull it to the front with root.lift() instead of creating another one. Add support for a callback in the preferences window when it's dismissed (with 'Cancel' or 'Save') to help track the liveness of the preferences window.

pwdirks commented 3 years ago

I just updated the 'pwd-243-limit-to-single-preferences-panel-at-runtime’ branch to include a change to also de-iconify the window when it’s brought to the front.

What’s the easiest way to get this in, too? If I create another merge request for the same branch, will that cause trouble or will it correctly incorporate the delta now on that branch?

Please try the new branch and let me know how you’d like to proceed?

Thanks and 73, -Patrick.

P.S. I’m not sure what the Mac equivalent of “iconify” is but I guess that’s the “minimize to the Dock” orange button in the window frame. I checked you can hide the window using that and it appears front-most, normal size, if you hit File -> Preferences again.

On Jan 19, 2021, at 3:09 PM, Ed Silky notifications@github.com wrote:

Merged #244 https://github.com/MorseKOB/PyKOB/pull/244 into master.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/MorseKOB/PyKOB/pull/244#event-4225089279, or unsubscribe https://github.com/notifications/unsubscribe-auth/ALTAYK66HCAT2MC3KLKTNC3S2YGLPANCNFSM4WIO3EIQ.

AESilky commented 3 years ago

Just push it. I left the server branch open, so that will allow a new pull to be created.

I just tested and it works fine.

-Ed

On Tue, Jan 19, 2021 at 3:21 PM Patrick Dirks notifications@github.com wrote:

I just updated the 'pwd-243-limit-to-single-preferences-panel-at-runtime’ branch to include a change to also de-iconify the window when it’s brought to the front.

What’s the easiest way to get this in, too? If I create another merge request for the same branch, will that cause trouble or will it correctly incorporate the delta now on that branch?

Please try the new branch and let me know how you’d like to proceed?

Thanks and 73, -Patrick.

P.S. I’m not sure what the Mac equivalent of “iconify” is but I guess that’s the “minimize to the Dock” orange button in the window frame. I checked you can hide the window using that and it appears front-most, normal size, if you hit File -> Preferences again.

On Jan 19, 2021, at 3:09 PM, Ed Silky notifications@github.com wrote:

Merged #244 https://github.com/MorseKOB/PyKOB/pull/244 into master.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub < https://github.com/MorseKOB/PyKOB/pull/244#event-4225089279>, or unsubscribe < https://github.com/notifications/unsubscribe-auth/ALTAYK66HCAT2MC3KLKTNC3S2YGLPANCNFSM4WIO3EIQ .

— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub https://github.com/MorseKOB/PyKOB/pull/244#issuecomment-763206464, or unsubscribe https://github.com/notifications/unsubscribe-auth/AETPXOZ2BD6KNKOQA434HBDS2YHYHANCNFSM4WIO3EIQ .

pwdirks commented 3 years ago

I’ve pushed the branch up to ‘origin’. Try merging the fix?

73, -Patrick.

On Jan 19, 2021, at 3:26 PM, Ed Silky notifications@github.com wrote:

Just push it. I left the server branch open, so that will allow a new pull to be created.

I just tested and it works fine.

-Ed

On Tue, Jan 19, 2021 at 3:21 PM Patrick Dirks notifications@github.com wrote:

I just updated the 'pwd-243-limit-to-single-preferences-panel-at-runtime’ branch to include a change to also de-iconify the window when it’s brought to the front.

What’s the easiest way to get this in, too? If I create another merge request for the same branch, will that cause trouble or will it correctly incorporate the delta now on that branch?

Please try the new branch and let me know how you’d like to proceed?

Thanks and 73, -Patrick.

P.S. I’m not sure what the Mac equivalent of “iconify” is but I guess that’s the “minimize to the Dock” orange button in the window frame. I checked you can hide the window using that and it appears front-most, normal size, if you hit File -> Preferences again.

On Jan 19, 2021, at 3:09 PM, Ed Silky notifications@github.com wrote:

Merged #244 https://github.com/MorseKOB/PyKOB/pull/244 into master.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub < https://github.com/MorseKOB/PyKOB/pull/244#event-4225089279>, or unsubscribe < https://github.com/notifications/unsubscribe-auth/ALTAYK66HCAT2MC3KLKTNC3S2YGLPANCNFSM4WIO3EIQ .

— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub https://github.com/MorseKOB/PyKOB/pull/244#issuecomment-763206464, or unsubscribe https://github.com/notifications/unsubscribe-auth/AETPXOZ2BD6KNKOQA434HBDS2YHYHANCNFSM4WIO3EIQ .

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/MorseKOB/PyKOB/pull/244#issuecomment-763208194, or unsubscribe https://github.com/notifications/unsubscribe-auth/ALTAYKY3SQNBDD5FNEUV3GLS2YII5ANCNFSM4WIO3EIQ.

AESilky commented 3 years ago

I haven't tested on my mac. I have changes open, so it's work to stash them and check there. I (kinda) figured you would test that. I can do a test on Linux.

AESilky commented 3 years ago

This works for me. You will need to open a new PR though (from the changes) so it can be merged.

pwdirks commented 3 years ago

Mac is the easy test for me - that’s where I do development. It works on macOS.

On Jan 19, 2021, at 3:29 PM, Ed Silky notifications@github.com wrote:

I haven't tested on my mac. I have changes open, so it's work to stash them and check there. I (kinda) figured you would test that. I can do a test on Linux.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/MorseKOB/PyKOB/pull/244#issuecomment-763209661, or unsubscribe https://github.com/notifications/unsubscribe-auth/ALTAYK3T5Y6RAJEBPPEAWELS2YIVZANCNFSM4WIO3EIQ.

pwdirks commented 3 years ago

OK - see #245 (If the preferences window is minimized ('iconified'), selecting 'Preferences' does not show the window as expected).

On Jan 19, 2021, at 3:34 PM, Patrick Dirks pwd@mac.com wrote:

Mac is the easy test for me - that’s where I do development. It works on macOS.

On Jan 19, 2021, at 3:29 PM, Ed Silky <notifications@github.com mailto:notifications@github.com> wrote:

I haven't tested on my mac. I have changes open, so it's work to stash them and check there. I (kinda) figured you would test that. I can do a test on Linux.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/MorseKOB/PyKOB/pull/244#issuecomment-763209661, or unsubscribe https://github.com/notifications/unsubscribe-auth/ALTAYK3T5Y6RAJEBPPEAWELS2YIVZANCNFSM4WIO3EIQ.

AESilky commented 3 years ago

Yes, me too (Mac is main dev machine). Only go to Windows machine for testing and Win specific issues. Just that right now I have changes in my Mac env that I would need to 'stash' in order to test this.