search

MortalreminderPT / edit-xlsx

A quick and easy-to-use Rust library for Excel file editing.
https://crates.io/crates/edit-xlsx
22 stars 4 forks source link

Dev 0.4 mschnell #12

Closed mschnell1 closed 5 months ago

mschnell1 commented 5 months ago

@MortalreminderPT Creates a runtime error in a library function.

MortalreminderPT commented 5 months ago

When I tested your example with several complex xlsx files under tests/xlsx, I found that there was an out-of-bounds problem with the modification of the widths, because the upper limit of the col range could exceed the length of the widths. I think this can be solved by passing in the max allowed upper limit when decoding the range. Additionally, I think your project is useful and valuable, do you plan to open source this project to your own repository?

mschnell1 commented 5 months ago

Right now I don't plan to manage projects on Github, as in the company we use a private Gitlab server for all our software. So I could either work on forks or directly push commits for reviewing to the main project, if appropriate.

mschnell1 commented 5 months ago

the upper limit of the col range could exceed the length of the widths. I think this can be solved by passing in the max allowed upper limit

Hmm I thought this should not happen.... Of course using max is save to avoid a panic, but do we loss some viable case with that ?