MortalreminderPT / edit-xlsx

A quick and easy-to-use Rust library for Excel file editing.
https://crates.io/crates/edit-xlsx
16 stars 4 forks source link

Implement std::error::Error for error types #19

Closed FlixCoder closed 1 month ago

FlixCoder commented 1 month ago

Thank you for the work on this crate, it looks nice!

I noticed that the error types do not implement std::error::Error, so they cannot be used in standard error handling and not conveniently converted to other errors.

MortalreminderPT commented 1 month ago

Thanks for the suggestion, I'll fix it in the future😃

MortalreminderPT commented 1 month ago

I implemented it in a new commit, you can see the corresponding test by clicking here

FlixCoder commented 1 month ago

Thanks!

MortalreminderPT commented 1 month ago

Thanks!

Thanks for the suggestion, if you encounter problems using the feature, you can reopen the issue😊