MortenTobiasNielsen / Factorio-TAS-Generator

This is an attempt to create a helper tool for Tool Assisted Speedruns in Factorio. A guide of how to use the tool can be found here: https://www.youtube.com/watch?v=V9tuNoDqc0E&t
MIT License
13 stars 4 forks source link

Refactor update parameters #285

Closed theis999 closed 1 year ago

theis999 commented 1 year ago

UpdateParameters has grown way to large. This should help reduce it's size. I have used the system of parameter_choices to find out which control elements that should be updated. I can reduce the size of the function further. However some of On___SelectMenu have more code in them so i would need to put the functions into a lookup table. I don't think it would be worth it currently.

It looks a bit silly to have a switch where all but one case seemingly does the same, but it should at least be easier to work with.

I removed building_orientation from Priority as the value isn't relevant. And the field is being used for priority. Can this cause issues?

This is built on #282 to get the select menu functions.