Change approach to read data till end of application data instead of chunk size

MortezaBashsiz / nipovpn

Powerfull http proxy

GNU General Public License v3.0

183 stars 11 forks source link

Change approach to read data till end of application data instead of chunk size #119

Closed MortezaBashsiz closed 6 days ago

MortezaBashsiz commented 1 month ago

Our current approach is not good will cause to combining chunks incorrectly or cutting them off in the middle of a critical part like a header. It should read data till end of each application data which can be readable from TLS header and then send it to agent

MortezaBashsiz commented 1 month ago

I have tested it and faced with breaking MAC integrity and reading them based on TLS records header is not good Idea and could break MAC

MortezaBashsiz commented 6 days ago

Fixed by merging branch #127