search

MortimerGoro / MGSwipeTableCell

An easy to use UITableViewCell subclass that allows to display swippable buttons with a variety of transitions.
MIT License
6.96k stars 1.07k forks source link

Fixed capture of the system table separator for snapshot #268

Closed KonstStrebkov closed 7 years ago

KonstStrebkov commented 7 years ago


Added fix to set the correct snapshot source and frame for swipe overlay. This will fix displaying snapshotted system separator above the original: separator

MortimerGoro commented 7 years ago

Hi KonstStrebkov,

Thanks for the PR. There is a problem by using contentView frame & imageFromView instead of self.bounds.width. It breaks swiping cells with accessoryViews because the controls are outside of the contentView itself. You can see what happens running the MGwipeDemo sample project and activating accesory views in the upper right menu.

We should only play with the cell/contentView height to fix this issue

KonstStrebkov commented 7 years ago

Hi MortimerGoro,

I got your point. Updated fix to manipulate only with cell/contentView height.

MortimerGoro commented 7 years ago

Thanks for the PR. Merged via https://github.com/MortimerGoro/MGSwipeTableCell/pull/283 to squash commits and make a minor change. You are still the author of the commit.