MortimerGoro / MGSwipeTableCell

An easy to use UITableViewCell subclass that allows to display swippable buttons with a variety of transitions.
MIT License
6.96k stars 1.07k forks source link

Hang on swipe in iOS 14.4 #358

Open toby5box opened 3 years ago

toby5box commented 3 years ago

Hi,

Testers on real phones and simulators (including me) are seeing a hang in swiping that does not occur on iOS 13.

At the same time, the log is spammed with these messages:

2021-04-14 15:04:48.790955-0400 BuildupDev[19163:221235] [Snapshotting] 
View (0x7f9e0a172800, BUTableViewCell) drawing with afterScreenUpdates:YES 
inside CoreAnimation commit is not supported.

(In our app, @interface BUTableViewCell : MGSwipeTableCell)

CPU is on 95% and memory continually rises so it looks something like an infinite loop. Screen Shot 2021-04-14 at 7 40 39 PM

Has anyone else reproduced this?

toby5box commented 3 years ago

Looks like the hang can be localised to imageFromView.

TobiasRe commented 3 years ago

I'm experiencing very similar behaviour. imageFromView causes the memory so spike until the app crashes.

MortimerGoro commented 3 years ago

I'm going to look into it. Can you reproduce it using any of the demos? https://github.com/MortimerGoro/MGSwipeTableCell/tree/master/demo/

tylerweitzman commented 3 years ago

I'm getting this too iOS 4.5 iPhone 12 Pro Max. Doesn't happen on simulator

tylerweitzman commented 3 years ago

I was able to fix by downgrading all the way down to version 1.6.6. Now it's no longer crashing, though it still hangs for a few seconds. Sadly, this is not very reproducible. I was able to consistently reproduce it only in a specific user's account in our app, and only by performing a fixed series of steps navigating to another view in the navigation, performing an action in that view, returning, to the root view, and then swiping and tapping.

aldukeman commented 3 years ago

Same experience here. App quickly runs out of memory and crashes. Will try reverting to 1.6.6