search

MortonArb-ForestEcology / REU2020-MODIS_phenology

Repository for code and analyses related to 2020 REU Andrew Ernat's project
1 stars 0 forks source link

Code Review 7/14 #1

Open crollinson opened 4 years ago

crollinson commented 4 years ago

@aernat -- Looking through your code and some things that should get fixed in a commit soon.

1) https://github.com/MortonArb-ForestEcology/REU2020-MODIS_phenology/blob/24be6d2e58ff5e50face585a4b8991ef5bca9d67/scripts/01b_NPN_data.R#L36 Does not match https://github.com/MortonArb-ForestEcology/REU2020-MODIS_phenology/blob/24be6d2e58ff5e50face585a4b8991ef5bca9d67/scripts/01b_NPN_data.R#L46

When you change out species, make sure you be consistent.

  1. relatedly, moving forward make sure all names, date ranges, etc. get updated to fit what you're doing. For example: https://github.com/MortonArb-ForestEcology/REU2020-MODIS_phenology/blob/24be6d2e58ff5e50face585a4b8991ef5bca9d67/scripts/02_Met_data_transform.R#L34

do you still want this labeled "TEST"

  1. now is a good time to go through and update your script numbers. We want to avoid having multiple scripts labeled 02_[...]. Make renaming its own commit with no changes to the code as part of it, because we won't be able to track that.

  2. make sure you update graph titles and save them as files to make it easier to track what is changing; e.g. https://github.com/MortonArb-ForestEcology/REU2020-MODIS_phenology/blob/24be6d2e58ff5e50face585a4b8991ef5bca9d67/scripts/02_NPN_data_clean.R#L84

  3. These lines don't work -- this is not where your cleaned data is being saved according to your code: https://github.com/MortonArb-ForestEcology/REU2020-MODIS_phenology/blob/24be6d2e58ff5e50face585a4b8991ef5bca9d67/scripts/04_DAYMET_NPN.R#L11-L12

crollinson commented 4 years ago

Add to list of issues: https://github.com/MortonArb-ForestEcology/REU2020-MODIS_phenology/blob/311b1a7db512e8bc734457180f59370dfaaac625/scripts/04_Model_bud_firstmin.R#L346 doesn't match what's in the write statements below it. Might be true in other scripts, but I haven't checked.