Morwenn / cpp-sort

Sorting algorithms & related tools for C++14
MIT License
621 stars 57 forks source link

Move CI to GitHub Actions #176

Closed Morwenn closed 3 years ago

Morwenn commented 3 years ago

I planned to move the continuous integration to GitHub Actions at some point, but the recent changes to Travis CI mean that we will likely have to move sooner rather than later.

Morwenn commented 3 years ago

Forgot to mention it, but commit 1de7526fc01d0f173d18d0ea93f55af57b850d38 add a workflow for Ubuntu.

Morwenn commented 3 years ago

I got the following kinds of builds working:

While a bit different from the old Travis CI builds, I believe that I cover an equivalent amount of possibilities. There main differences are as follows:

This is pretty satisfying as everything runs smoothly. There are a few additional steps before closing the issue:

Morwenn commented 3 years ago

Commits 2cc9016a0830f70906b98ee194514ce75176dc89 and 13157e2aa1fccc43d5eb0e7dffd40f431de64b71 simplify the MacOS and Ubuntu build matrices respectively, making them more understandable, less redundant, and easier to maintain.

Morwenn commented 3 years ago

actions/cache@v2 has some significant drawbacks so far:

Considering that the build times are currently decent even with a full rebuild, I consider that making the workflows more complicated is not worth my time. I might give it another try in the future once features and usages have evolved, but currently it's got more cons than pros.

As such, I consider that this issue is in a good enough state for now, and ready to ship.