search

Morwenn / cpp-sort

Sorting algorithms & related tools for C++14
MIT License
617 stars 57 forks source link

MSVC tests don't work anymore #195

Closed Morwenn closed 2 years ago

Morwenn commented 2 years ago

I somehow never noticed it because the job does not explicitly fail, but MSVC tests probably haven't been working for a while. I've got no issue reproducing the issue locally and running the generated main-tests.exe with --list-tests returns nothing, so that feels like a weird silent error that I will likely have to bisect.

I guess that it is another point for a "no tests means error" behaviour.

Morwenn commented 2 years ago

According to git bisect, it's yet another error linked to the change in random utilities in the test suite, and once again it seems to be a thread_local issue, which is becoming a bit annoying to say the least.