search

Morwenn / cpp-sort

Sorting algorithms & related tools for C++14
MIT License
624 stars 58 forks source link

clang-cl support #208

Closed Morwenn closed 2 years ago

Morwenn commented 2 years ago

Considering what I have been told about clang-cl, I am pretty sure that cpp-sort doesn't properly work with it nowadays. Try to use it, and fix the library as needed.

Morwenn commented 2 years ago

Fixing an issue with __[u]int128_t introduced in 1.13.1 was surprisingly enough to get clang-cl to build modulo a few (hundreds of) warnings. Most of the platform-specific #ifdef in the library were surprisingly ordered the correct way to make everything work, which is as lucky as I get.

I added a Debug clang-cl build to CI, but the corresponding Release build crashes during the compilation process. The error makes it look like a memory issue, and it does compile and run locally so I'm pretty positive that it's a CI-only issue and not an issue on the library side.