Closed jeffklassen closed 7 years ago
A few observations:
Otherwise LGTM. Good work!
@BKreisel What do you mean about the custom couples sign ups? When the group type is 'Couples' it works:
@BKreisel ah -- I see that if it is 'Married Couples' it does not work. Is that what you are seeing or are you seeing something else?
@jeffklassen: Ah yes, I did my testing with a "married couples"group. That appears to be the issue.
Addressed with some ES2016 Array.prototype.includes() magic
@BKreisel Man, I really like your solution. We might want to pull that out into its own function. Maybe add this to utils and have a
const isCouplyGroup =(group) ={
return ['Couples, 'Married couples'].includes(group.audienceType);
}
just so we are not copying logic around and having to maintain that logic in multiple places.
Oh.. heh.. you did that!!!!
The group join form should be complete