MosaicGroups / mosaic-groups

A Mosaic groups application
GNU General Public License v3.0
6 stars 2 forks source link

Hide group once full (High Priority) #139

Closed amandawmosaic closed 7 years ago

amandawmosaic commented 7 years ago

Can we remove a group from the public display once it's filled?

If it's possible to accomplish this before the weekend I will award 10 points to Gryffindor.

jeffklassen commented 7 years ago

@amandawmosaic do we want people to be completely unable to view full groups, or do we want to just clean up the ui?

A simple way to handle this would be for me to set the hide full groups check box to checked, but then of course the user could uncheck the box:

screen shot 2017-05-04 at 4 27 28 pm
amandawmosaic commented 7 years ago

I don't want anyone to be able to see a group once it's filled ever. We have wait lists stacking up, and it's preventing people from getting into other groups.

jeffklassen commented 7 years ago

Do you want to be able to see full groups, or do you fall into the 'anyone' who should ever see full groups ever?

On Thu, May 4, 2017 at 4:31 PM, amandawmosaic notifications@github.com wrote:

I don't want anyone to be able to see a group once it's filled ever. We have wait lists stacking up, and it's preventing people from getting into other groups.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/MosaicGroups/mosaic-groups/issues/139#issuecomment-299202500, or mute the thread https://github.com/notifications/unsubscribe-auth/AHCOwFFOmtY1SyoLLqbCU10STHFw0GPmks5r2eExgaJpZM4NQvf3 .

amandawmosaic commented 7 years ago

Nope, I'm special. I'd like myself and Jess to still be able to see them if possible.

jeffklassen commented 7 years ago

Okay can do. Can we just hide them from the UI? The implications of this being that a hacker could view full groups, but they wont be shown on the page to anyone but admins.

Does that sound good?

On Thu, May 4, 2017 at 4:40 PM, amandawmosaic notifications@github.com wrote:

Nope, I'm special. I'd like myself and Jess to still be able to see them if possible.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/MosaicGroups/mosaic-groups/issues/139#issuecomment-299205255, or mute the thread https://github.com/notifications/unsubscribe-auth/AHCOwJC3zyQjq3xMZcuWQmPU37AfLk_9ks5r2eNLgaJpZM4NQvf3 .

amandawmosaic commented 7 years ago

Sounds great.

jeffklassen commented 7 years ago

I've fixed this -- PLEASE go into the app ASAP and make sure everything works exactly how you think it should (by logging in, and making sure you see the groups you want to see and then logging out and making sure you see the groups you want to see.

On Thu, May 4, 2017 at 4:48 PM, amandawmosaic notifications@github.com wrote:

Sounds great.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/MosaicGroups/mosaic-groups/issues/139#issuecomment-299207948, or mute the thread https://github.com/notifications/unsubscribe-auth/AHCOwJ9GPdKgLRHItiYx8-Tz0kjxPFq5ks5r2eVSgaJpZM4NQvf3 .

amandawmosaic commented 7 years ago

OK the UI looks awesome. Here's the one thing I didn't account for. Group leaders need to be able to see their groups when they login to pull information and make changes to their rosters.

Can you make it so leaders can see the full groups when they're logged in?