MosaicGroups / mosaic-groups

A Mosaic groups application
GNU General Public License v3.0
6 stars 2 forks source link

JavaScript Error #171

Closed mnmercer closed 7 years ago

mnmercer commented 7 years ago

On opening the site, I get this error in the JavaScript console.

screen shot 2017-05-18 at 10 08 20 am
jeffklassen commented 7 years ago

Please include steps to reproduce

On May 18, 2017 16:09, "mnmercer" notifications@github.com wrote:

On opening the site, I get this error in the JavaScript console. [image: screen shot 2017-05-18 at 10 08 20 am] https://cloud.githubusercontent.com/assets/9361260/26206164/0a34694a-3bb2-11e7-8064-30d008046942.png

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/MosaicGroups/mosaic-groups/issues/171, or mute the thread https://github.com/notifications/unsubscribe-auth/AHCOwL_OtEVXlsvXQ5aomFi4dIFBgbhfks5r7FEPgaJpZM4NfSZg .

mnmercer commented 7 years ago

@jeffklassen Steps to reproduce:

  1. Open https://mosaicgroups-dev.herokuapp.com/ or start up a running local instance on the react-dev branch in a Chrome browser.

There's actually a different error being thrown when opening the application in Firefox.

screen shot 2017-05-18 at 11 36 23 am
jeffklassen commented 7 years ago

Ah! I see. If you build with webpack-watch, do you get a better stacktrace?

On May 18, 2017 17:34, "mnmercer" notifications@github.com wrote:

@jeffklassen https://github.com/jeffklassen Steps to reproduce:

  1. Open https://mosaicgroups-dev.herokuapp.com/ or start up a running local instance on the react-dev branch.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/MosaicGroups/mosaic-groups/issues/171#issuecomment-302442224, or mute the thread https://github.com/notifications/unsubscribe-auth/AHCOwGQ1OcgHR9d2gC5_vTgUJxAPshO1ks5r7GUSgaJpZM4NfSZg .

mnmercer commented 7 years ago

Yeah. Now the Chrome error looks like this.

screen shot 2017-05-18 at 11 47 18 am

The Firefox error looks like this. I couldn't capture the entire stack trace, but I think this will be informative enough.

screen shot 2017-05-18 at 11 48 46 am
jeffklassen commented 7 years ago

That's great! Looks like we just need to check if(identity.roles && identity.roles includes....

On May 18, 2017 17:49, "mnmercer" notifications@github.com wrote:

Yeah. Now the Chrome error looks like this. [image: screen shot 2017-05-18 at 11 47 18 am] https://cloud.githubusercontent.com/assets/9361260/26211149/cfb92590-3bbf-11e7-9fba-19cd169d54da.png The Firefox error looks like this. I couldn't capture the entire stack trace, but I think this will be informative enough. [image: screen shot 2017-05-18 at 11 48 46 am] https://cloud.githubusercontent.com/assets/9361260/26211206/040442ee-3bc0-11e7-983d-3943dd7100e0.png

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/MosaicGroups/mosaic-groups/issues/171#issuecomment-302446564, or mute the thread https://github.com/notifications/unsubscribe-auth/AHCOwNd4T1Ld_GlKNelu1OO8ipOju3Nxks5r7GiIgaJpZM4NfSZg .

jeffklassen commented 7 years ago

@mnmercer Man - i can't reproduce the error:

screen shot 2017-05-19 at 12 44 14 pm
jeffklassen commented 7 years ago

Never mind, I just duplicated it. It looks like you have to be logged out to trigger it. Fixing now.

jeffklassen commented 7 years ago

Done!