MosaicManufacturing / canvas-issues

Bug reports and feature requests for Canvas
https://canvas3d.io
8 stars 6 forks source link

Import printer-profile created in Simplify3d v5.01 failed #264

Closed Muratore73 closed 1 year ago

Muratore73 commented 1 year ago

Describe the bug The import of printer-profiles created with new Simplify3D v5.01 fail with error: "Cannot read properties of null (reading 'replace')"

To Reproduce Steps to reproduce the behavior:

  1. Log on to https://www.canvas3d.io/
  2. Click on 'printers'
  3. Click on '+ New Printer'
  4. Select 'Import'
  5. Select file to import

Expected behavior Import printer-profile an create new printer in Canvas.

Operating System (please complete the following information):

Additional context

brandonbloch commented 1 year ago

Hi @Muratore73,

Thanks for reporting this issue! We were made aware of this problem a few days ago and realized that while the underlying format of S3D profiles hasn't changed in v5 (i.e. XML files with .fff extension), the actual content is significantly different. We're working on a fix for this in order to support importing these profiles, but unfortunately there isn't a good workaround in the meantime other than manually creating a Canvas profile with the same settings.

I'll leave the issue open until full support for S3D v5 import is available in Canvas.

Cheers, Brandon

Muratore73 commented 1 year ago

Hi Brandon

Thanks for your support on this. If can help testing, or provide some S3D-profiles, let me know.

Kind regards Christoph

Gesendet von Mailhttps://go.microsoft.com/fwlink/?LinkId=550986 für Windows

Von: Brandon @.> Gesendet: Freitag, 17. Februar 2023 18:48 An: @.> Cc: Christoph @.>; @.> Betreff: Re: [MosaicManufacturing/canvas-issues] Import printer-profile created in Simplify3d v5.01 failed (Issue #264)

Hi @Muratore73https://github.com/Muratore73,

Thanks for reporting this issue! We were made aware of this problem a few days ago and realized that while the underlying format of S3D profiles hasn't changed in v5 (i.e. XML files with .fff extension), the actual content is significantly different. We're working on a fix for this in order to support importing these profiles, but unfortunately there isn't a good workaround in the meantime other than manually creating a Canvas profile with the same settings.

I'll leave the issue open until full support for S3D v5 import is available in Canvas.

Cheers, Brandon

— Reply to this email directly, view it on GitHubhttps://github.com/MosaicManufacturing/canvas-issues/issues/264#issuecomment-1435023142, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ANGQ5WUANDWNNVMFT4SFRZ3WX62WLANCNFSM6AAAAAAU7EOC5E. You are receiving this because you were mentioned.Message ID: @.***>

brandonbloch commented 1 year ago

Hi @Muratore73, thanks for the offer! We do have a couple of profiles we're using to test the new logic, but if you have any profiles you're willing to post here that would certainly be appreciated, particularly ones with different/non-standard variations of configuration. If you're not willing to post them publicly but are fine with us adding them to our collection of test profiles, you can send them my way at brandon@mosaicmfg.com.

Cheers, Brandon

a55830 commented 1 year ago

CrealityCR-6_max.zip hope you can use this, i realy need that to work

brandonbloch commented 1 year ago

Thanks @a55830, I'll include this in our test suite. We expect to have this feature available next week.

Cheers, brandon

brandonbloch commented 1 year ago

Hi all, support for S3D v5 profile import is now available! I'll close this issue as completed; if you have any other questions feel free to continue commenting in this thread, or if you're still experiencing errors feel free to re-open it.

Cheers, Brandon

Muratore73 commented 1 year ago

Hi Brandon

Import for S3Dv5-Profile works perfectly now. Thanks for this great support!!!

Kind regards Christoph

Gesendet von Mailhttps://go.microsoft.com/fwlink/?LinkId=550986 für Windows

Von: Brandon @.> Gesendet: Dienstag, 21. März 2023 17:06 An: @.> Cc: Christoph @.>; @.> Betreff: Re: [MosaicManufacturing/canvas-issues] Import printer-profile created in Simplify3d v5.01 failed (Issue #264)

Hi all, support for S3D v5 profile import is now available! I'll close this issue as completed; if you have any other questions feel free to continue commenting in this thread, or if you're still experiencing errors feel free to re-open it.

Cheers, Brandon

— Reply to this email directly, view it on GitHubhttps://github.com/MosaicManufacturing/canvas-issues/issues/264#issuecomment-1478122107, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ANGQ5WXE7JVATFECXZQP7RDW5HGYBANCNFSM6AAAAAAU7EOC5E. You are receiving this because you were mentioned.Message ID: @.***>