MoscaDotTo / Winapp2

A database of extended cleaning routines for popular Windows PC based maintenance software.
Creative Commons Attribution Share Alike 4.0 International
753 stars 85 forks source link

Issues with GOG Galaxy #948

Open LinguaOccultus opened 1 month ago

LinguaOccultus commented 1 month ago

Hello,

I am using CCEnhancer (https://singularlabs.com/software/ccenhancer/) and was told, this is the winapp2.ini file, it downloads.

Currently, there is an issue with the cleaning rule for Games/Galaxy. When using it, it removes also customizations for the list views of the GOG Galaxy client which is surely unintended. For example, hidden columns re-appear and sorting is reset also. It seems like the GOG Galaxy client writes those settings to a file which gets deleted with this rule. Unfortunately, I have not found out by now, which one. Aside that, it is completely reproducable and since I excluded this rule, everything is fine again.

Best regards,

Tim

TZocker commented 1 month ago

Hi Tim,

I can repruduce your ussue. But I think it's the same with browser celaning ....

The rule deletes lokal settings for sorting the gamelist to default.

PS: Hidden games are hidden after cleaning.

I would suggest to creat a warning.

Best regards.

LinguaOccultus commented 1 month ago

Hi,

I know that this game is always a trade-off between the stuff you want (like logs, caches, etc.) to delete and stuff you want to keep (like application settings, for example). Sometimes it is possible to separate them and create two rules instead which is why I wanted your attention on it.

Anyway, when not possible: yes, a warning should be placed since most users surely will want to keep their settings.

Hidden games seems to be my error and I am quite sure this is a global setting on the servers so they are not visible in the web library, too.

I come every now and them to a point like this and will report them in here directly now, so the CCEnhancer guy (Shawn or Shane?) does not have to forward them anymore! ;-)

Thanks and greetings,

Tim

TZocker commented 1 month ago

Hi, So i think its one file in:

C:\ProgramData\GOG.com\Galaxy\webcache\common\Local Storage\leveldb

ExcludeKey1=PATH|%CommonAppData%\GOG.com\Galaxy\webcache\common\Local Storage\leveldb|*.*

On my pc 000003.log ....

We have to make more research.

Can you test it, pls?

APMichael commented 1 month ago

The environment variable %CommonAppData% was apparently replaced by the variable %ProgramData% after the big overhaul. And with an ExcludeKey, the path should always end with \|.

The ExcludeKey should therefore look like this: ExcludeKey1=PATH|%ProgramData%\GOG.com\Galaxy\webcache\common\Local Storage\leveldb\|*

LinguaOccultus commented 1 month ago

Hello,

thanks for the feedback. Unfortunately, I am on the road for a few days from work, so I cannot test this immediately ...

TZocker commented 1 month ago

The environment variable %CommonAppData% was apparently replaced by the variable %ProgramData% after the big overhaul. And with an ExcludeKey, the path should always end with \|.

The ExcludeKey should therefore look like this: ExcludeKey1=PATH|%ProgramData%\GOG.com\Galaxy\webcache\common\Local Storage\leveldb\|*

Thx, for the information but it's not noticed in the readme ...

APMichael commented 1 month ago

I just noticed today that all %CommonAppData% have been replaced by %ProgramData%. 😄

TZocker commented 1 month ago

Next big search and replacement ? :D

APMichael commented 2 weeks ago

... Unfortunately, I am on the road for a few days from work, so I cannot test this immediately ...

Have you had time to test the ExcludeKey? Does it work as intended?

https://github.com/MoscaDotTo/Winapp2/issues/948#issuecomment-2144679075

LinguaOccultus commented 2 weeks ago

Sorry, misunderstood you here. Thought, I was meant to wait until this is released. I always check with CCEnhancer before each CCleaner use and since the warning also is still missing ...

Anyway, with the latest GOG Galaxy version this seems to work in a quick first test. Seems they really made some changes again, but the 2.0 version I am using is in beta for how many YEARS now? :-D So I guess, we will see changes here again.

APMichael commented 2 weeks ago

Thank you for your reply. Then @TZocker can update his pull request https://github.com/MoscaDotTo/Winapp2/pull/949 accordingly.

LinguaOccultus commented 2 weeks ago

No worries; I will test again as soon as there is the warning implemented as I know then the rule is updated.

TZocker commented 2 weeks ago

https://github.com/MoscaDotTo/Winapp2/pull/949/files#diff-9873d4e96e8358591fcf9143d9c896437b7fda74347968f3357e66c6c84e30e2