MosheBenZacharia / GP-Per-Hour

BSD 2-Clause "Simplified" License
2 stars 3 forks source link

Compatibility with Customizable XP Drops #1

Open CreativeTechGuy opened 1 year ago

CreativeTechGuy commented 1 year ago

I've been tracking this plugin since it seems incredibly well done so I jumped on it as soon as it was released. Unfortunately, it seems like it is partially incompatible with the Customizable XP drops plugin which override the XP drop UI. Instead of showing the coins in profit/loss mode, it shows the following.

image

Would it be reasonable to ask for either compatibility with that plugin, or a different UI option for your plugin so that it avoids the compatibility issues entirely? A simple solution might be to show the gold drops right next to the trip overlay sort of like this. It would be static, appear for a few seconds, and then disappear. If there was another gold drop before the first one disappeared, the numbers would add together and the disappear time would reset.

image

Anyway, thank you so much for this amazing plugin. I'm sure you'll come up with something clever to solve this problem.

MosheBenZacharia commented 1 year ago

Hey, thanks so much for the kind words and all the great feedback!

Compatibility with the Customizable XP Drops plugin seems tricky since they completely hide the vanilla UI and there doesn't seem to be a way to add custom XP drops from other plugins.

I like the idea of adding a separate UI option entirely for those who want it, I can definitely look into it!

MosheBenZacharia commented 1 year ago

added an option for static gold drops here: https://github.com/MosheBenZacharia/GP-Per-Hour/commit/76da094fbc75404d913eacfe46a5c238cdd05dd3

will close this issue when it merges into plugin hub

edit: merged in https://github.com/runelite/plugin-hub/pull/4997 . but will keep this open to address your comments

CreativeTechGuy commented 1 year ago

Not sure if this was intentional, but the static gold drops are weirdly positioned:

image

They don't really align with anything. It seems like it's a relative position compared to where the overlay is but it doesn't look configurable.

MosheBenZacharia commented 1 year ago

Hey, I tried to make it line up it to be under where customizable xp drops appear with their default config setup.

I originally tried having it next to the overlay but it would render underneath the vanilla UI.

If you have other ideas I'm all ears, also feel free to submit a PR if you have a good implementation in mind.

Syrinok commented 1 year ago

Being able to move things around with Alt + Left click would be nice, are there limitations preventing that?

CreativeTechGuy commented 1 year ago

@Syrinok that's what I was hoping for for all of the UI. It'd be great if both the gold "drops" and the total value badge were (separate) RuneLite overlay that could be Alt-dragged around. That'd be much easier to customize it. Example

MosheBenZacharia commented 1 year ago

Thanks for the feedback guys, this shouldn't be too hard, I will definitely look into it!

Intecpsp commented 5 months ago

Any update on this?

MosheBenZacharia commented 5 months ago

Nope, haven't had a chance to look into this yet.