search

MosheBenZacharia / GP-Per-Hour

BSD 2-Clause "Simplified" License
2 stars 3 forks source link

Issue with Leprechaun/Log Basket #14

Open Teichnician opened 11 months ago

Teichnician commented 11 months ago

Love the plug in! I noticed today while doing forestry that the plugin is not able to accurately track gp gained when logs go into an open basket (sometimes it does though?). Also, when I bank logs with the leprechaun it subtracts the logs from GP gained.

MosheBenZacharia commented 11 months ago

Huh, that is strange. Are you using a log basket or do you have the forestry basket? It should track logs in the log basket properly.

I hadn't thought of what happens when banking with the leprechaun but I can definitely make a fix for that.

Teichnician commented 11 months ago

Just using the normal log basket with it open. It doesn't seem to be a consistent problem however. On my laptop Runelite I don't have the item charges plugin installed, but I do on my PC, and haven't experienced the issue while playing on my PC yet. That may just be coincidence though idk if there's cross-talk between the two plugins.

On Mon, Oct 16, 2023, 9:07 PM Mo Ben-Zacharia @.***> wrote:

Huh, that is strange. Are you using a log basket or do you have the forestry basket? It should track logs in the log basket properly.

I hadn't thought of what happens when banking with the leprechaun but I can definitely make a fix for that.

— Reply to this email directly, view it on GitHub https://github.com/MosheBenZacharia/GP-Per-Hour/issues/14#issuecomment-1765541196, or unsubscribe https://github.com/notifications/unsubscribe-auth/BDKOLJH5SQM2S7GUNVFPJC3X7XR5ZAVCNFSM6AAAAAA6DAVMO2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTONRVGU2DCMJZGY . You are receiving this because you authored the thread.Message ID: @.***>

MosheBenZacharia commented 11 months ago

That is very weird, I'll see if I can reproduce it as well. Let me know if you are able to figure out under what circumstances it happens.

Teichnician commented 11 months ago

Will do. I also noticed today when depositing seeds to the seed vault, the plugin treats it as profit loss.

On Mon, Oct 16, 2023, 9:57 PM Mo Ben-Zacharia @.***> wrote:

That is very weird, I'll see if I can reproduce it as well. Let me know if you are able to figure out under what circumstances it happens.

— Reply to this email directly, view it on GitHub https://github.com/MosheBenZacharia/GP-Per-Hour/issues/14#issuecomment-1765582890, or unsubscribe https://github.com/notifications/unsubscribe-auth/BDKOLJBZFMR2O3OUMNEYBPTX7XX25AVCNFSM6AAAAAA6DAVMO2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTONRVGU4DEOBZGA . You are receiving this because you authored the thread.Message ID: @.***>

MosheBenZacharia commented 11 months ago

oh good find, I'll open a bug for that as well.

Teichnician commented 11 months ago

Ok I've got some info on the log basket situation. For me, it seems like the GP/hr plugin is not reliant on the item charges improved plug-in as I initially thought, however there are still some weird interactions between GP/hr and the log basket. For one, if you use the check option when right clicking log basket and the number is less than it previously was (i.e. banked with leprechaun) it will incorrectly subtract from the profit calculation. Additionally, if the log basket thinks it is full (i.e. item charge of 28 but not actually full), any logs cut and added to the basket aren't added to profit calculation. Lastly, similar to the seed vault deposits, depositing with the leprechaun also subtracts from profit calculation.

I realize this is a bit long-winded so if you want to follow-up on discord or something let me know.

On Tue, Oct 17, 2023 at 6:08 PM Mo Ben-Zacharia @.***> wrote:

oh good find, I'll open a bug for that as well.

— Reply to this email directly, view it on GitHub https://github.com/MosheBenZacharia/GP-Per-Hour/issues/14#issuecomment-1767331810, or unsubscribe https://github.com/notifications/unsubscribe-auth/BDKOLJE3MHQJAVK424EYWNDX74FXZAVCNFSM6AAAAAA6DAVMO2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTONRXGMZTCOBRGA . You are receiving this because you authored the thread.Message ID: @.***>

MosheBenZacharia commented 11 months ago

Ah, that definitely makes sense, so essentially the tool leprechaun is causing all sorts of issues!

Man that is going to be a pain to test, if you're able to get a screenshot of the message in chat when a tool leprechaun banks your logs (if it exists) that would be super helpful for me to deploy a fix. If there is a separate message for when you bank your inventory and when you use your log basket on him I would need that too.