search

MosheBenZacharia / GP-Per-Hour

BSD 2-Clause "Simplified" License
2 stars 3 forks source link

Session loot grid forces client resize when not maximized #36

Open p00rleno opened 7 months ago

p00rleno commented 7 months ago

When the number of items in history gets large, the plugin will force the client to resize up to its vertical maximum if in a resizable mode to accommodate the grid instead of causing a scrollbar. On systems with particularly large vertical resolution (e.g. I have 4 3440x1440 ultrawides in a 2x2 grid), this can cause the client to largely go outside the usable area of the monitors. It also prevents the client from being resized any smaller by any means other than switching plugin tabs first, or first hiding the grid, or (ironically) maximizing the window.

Seems pretty easy to repro, other than getting a list of items in the log long enough to force it... here is one such grid that was causing the bad behavior: image

MosheBenZacharia commented 7 months ago

Ah, yes this is one of those UI bugs that is quite annoying to fix since setting up scrollable panels is super tricky. I added the session grid toggle button for that reason, but eventually I'd like to fix this properly.

MosheBenZacharia commented 2 months ago

I added a max height on the session loot grid in 02dad7505effedb5e136fcfa11311c0fb8806843

will hopefully make it into a PR soon

p00rleno commented 2 months ago

Cool, will give it a test when its eventually merged. Thanks.