search

MosheBenZacharia / GP-Per-Hour

BSD 2-Clause "Simplified" License
2 stars 3 forks source link

Tome of Fire won't calibrate with Varlamore update #53

Open daboross opened 2 weeks ago

daboross commented 2 weeks ago

Hi!

I just started using this - love the plugin.

it seems like the Tome of Fire won't calibrate - I think the plugin may be expecting a different message than the one the game is providing me.

I see this message in the client log:

2024-08-24 23:36:16 PDT [Client] WARN  c.g.w.WeaponChargesManager - checked weapons with no check message: [TOME_OF_FIRE]

Here's a screenshot of the different chat messages:

zbsh: Checking tome of water. Your tome currently holds 3,087 charges. zbsh: Checking tome of fire. Your tome has been charged with Burnt Pages. It currently holds 3,282 charges.

Using the chat logs plugin, I captured the message as:

00:20:38 Your tome has been charged with Burnt Pages. It currently holds 3,282 charges.

I assume this is due to the addition of https://oldschool.runescape.wiki/w/Searing_page, and that the tome of fire has a new alternate output message as well if charged with searing pages as opposed to burnt pages.

Looks like this was fixed in weapons-manager with https://github.com/geheur/weapon-charges/commit/7046c15450500c9623aed532b6e0e08acaa6a21f -- I'm not sure if that's relevant.

MosheBenZacharia commented 2 weeks ago

Hey, thanks for reporting this! It is indeed relevant, as all the weapon charge code is copied from Geheur's plugin. I went ahead and updated the relevant sections and added it to the PR I have open here: https://github.com/runelite/plugin-hub/pull/6510#issuecomment-2308533059

This should be fixed when that PR is merged!

daboross commented 4 days ago

Thanks for implementing this!