search

MosheBerman / Surfboard

Surfboard is a delightful onboarding framework for iOS.
MIT License
441 stars 54 forks source link

Using "Screen" #9

Open oferRounds opened 8 years ago

oferRounds commented 8 years ago

Hi @MosheBerman

I'd like to use the screen to show a screenshots of my app inside the iPhone.

The thing is that when I use them (my screenshots are iPhone 5 proportions) they don't seem to fall in the right place (i.e. they don't occupy the entire iPhone screen).

Any idea what might be the issue?

MosheBerman commented 8 years ago

Yes, I think I know what the issue is.

There's a lot go auto layout stuff going on, and when I did this I wasn't as fluent as I am now. I never got it working 100% with all of the different screen sizes, and It's something I'd like to get right.

The issue has to do with the image overlay. I don't remember if the layout was done in a storyboard or in code, but I'll take a look when I have a chance, if you'd like me to. (Feel free to look too - a pull request will get this resolved a lot quicker. 😄)

Can you post a screenshot of your incorrectly rendered screenshots? (Even if the contents are blurred, as long the dimensions and flat edges are still there, so I can see the exact manifestation of the problem.)

Thanks for reporting, and I'll do my best to look.

MosheBerman commented 8 years ago

Also, #3 is related.

oferRounds commented 8 years ago

Hi @MosheBerman

Thanks for your answer and sorry for my delay! Let me try to fix it. I'm on it.

MosheBerman commented 8 years ago

Thanks! 😄

oferRounds commented 8 years ago

Hi @MosheBerman Just wanted to update that I won't get to fix the bug... I'm sorry for that.

MosheBerman commented 8 years ago

No worries. If/when I do, I'll let you know here.

oferRounds commented 8 years ago

Thank you! :)