Closed rysiulg closed 1 month ago
I will wait with 210 to apply 0 and 5 ;) registers
This pull request is for register 0, please do not add other changes. For register 5 make a separate request and remove it from this one.
This pull request is for register 0, please do not add other changes. For register 5 make a separate request and remove it from this one.
Sorry I can't find how to revert last with update register 5 -i can give you login to my github if you know how to do it. I've corrected with your suggestions reg: 0 and similary maked reg:5, and after save it automatically pulled. I don't have a previous copy to copy to notepad etc, and started again from scratch... -yes i want help to be one universal code, but started for forth one is too much for me;( -register 5 isn't so big -please check it -registers 210 and 211 are bigger -there are 16 + and 15- sensors...
Sorry I can't find how to revert last with update register 5 -i can give you login to my github if you know how to do it.
I would push a new change where you remove that register 5 code. You do not have to use all kind of git magic to revert it 😉
@rysiulg many thanks for this pull request. I tested it and it looks very good.
yes;;)previous only allow heat dhw or zone1 or zone2 -not all togetherso consider change names to power in name;)also for newbie i think is better to use secret and api defined -even with comment -but its your choice;) -i personally hate use phone to initially connect wifi;)PozdrawiamRyszard GwizdakMARM.pl Sp. z o.o.Wiadomość napisana przez Richard Arends @.***> w dniu 16.10.2024, o godz. 17:05: @rysiulg many thanks for this pull request. I tested it and it looks very good.
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you were mentioned.Message ID: @.***>
There are also a lot of people who like the one-time phone setup, which makes it easy for them to adopt the new device without even touching the computer. So for every use case there is something to say :)
Again thanks for this one and looking forward to your other changes !
Update Register 0 to be fully configurable (previously was impossible to set more than 1 option select. Commented reserved bits of register 0 -why make garbage in HA -better is leave code as commented for future -if there will be need to add functionality when producer implement it. Changed globasl from int to uint16_t -same as modbus register values