Mostela / pix-qrcode

Lib for create and show QRCode to PIX, you can show this code in another applications for payment by final consumer.
15 stars 7 forks source link

implement new types of key #1

Open NathanAllmeida opened 2 years ago

sourcery-ai[bot] commented 2 years ago

Sourcery Code Quality Report

❌  Merging this PR will decrease code quality in the affected files by 12.61%.

Quality metrics Before After Change
Complexity 2.25 ⭐ 5.32 ⭐ 3.07 👎
Method Length 27.57 ⭐ 39.62 ⭐ 12.05 👎
Working memory 4.70 ⭐ 7.00 🙂 2.30 👎
Quality 88.86% 76.25% -12.61% 👎
Other metrics Before After Change
Lines 73 139 66
Changed files Quality Before Quality After Quality Change
pixqrcode/service/generate_code.py 89.44% ⭐ 82.28% ⭐ -7.16% 👎
pixqrcode/service/validate_pix.py 88.70% ⭐ 75.15% ⭐ -13.55% 👎

Here are some functions in these files that still need a tune-up:

File Function Complexity Length Working Memory Quality Recommendation
pixqrcode/service/generate_code.py GenerateCode.generate 0 ⭐ 91 🙂 21 ⛔ 57.40% 🙂 Extract out complex expressions
pixqrcode/service/validate_pix.py ValidatePix.detect_type_key 12 🙂 92 🙂 10 😞 58.61% 🙂 Extract out complex expressions
pixqrcode/service/validate_pix.py ValidatePix.validateCPF 4 ⭐ 129 😞 7 🙂 67.92% 🙂 Try splitting into smaller methods

Legend and Explanation

The emojis denote the absolute quality of the code:

The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request.


Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Help us improve this quality report!

NathanAllmeida commented 2 years ago

Olá Vi seu repositório e vi que aceitava apenas chave telefone, fiz umas mudanças para aceitar outras. Sou iniciante em python então aceito sugestões também

Mostela commented 2 years ago

Olá Vi seu repositório e vi que aceitava apenas chave telefone, fiz umas mudanças para aceitar outras. Sou iniciante em python então aceito sugestões também

Que legal!! Fico muito feliz pela contribuição sua :smile: