MostlyAdequate / mostly-adequate-guide

Mostly adequate guide to FP (in javascript)
Other
23.44k stars 1.87k forks source link

Gitbook appears to be stale/behind master #597

Closed etmoore closed 3 years ago

etmoore commented 3 years ago

It appears the Gitbook version is out of date (ie behind master).

evidence noticed so far:

Any chance the Gitbook version can be updated? πŸ™

etmoore commented 3 years ago

πŸ€” Looks like something was changed/updated, as I now see "Goodbye cruel world" in the gitbook (here) image … and I see append in appendix C now (here). image

Cool πŸ‘ Thanks! Closing.

KtorZ commented 3 years ago

Yes, sorry for not notifying. I attempted a migration on gitbook but was dragged into something else and didn't have time to check if it did work or not. Sounds like it did :)

etmoore commented 3 years ago

@KtorZ The text is updated (❀️), but the migration appears to have resulted in a few other issues 😬

  1. Exercises no longer work… they're just static text (see https://mostly-adequate.gitbook.io/mostly-adequate-guide/ch04#lets-practice)

    image
  2. The book logo is broken

    image
  3. The sub-chapter navigation on the left side of the page doesn't work. Rather than linking to the appropriate header, it links to a subpath that doesn't exist. eg ch03/oh-to-be-pure-again instead of ch03#oh-to-be-pure-again

    image

    The good news is that the "Contents" navigation in the top right corner does work.

Happy to create separate issues for these if you'd like! Appreciate your help πŸ˜„

etmoore commented 3 years ago

Ah, I see another issue has already been created for the broken in-browser exercises: https://github.com/MostlyAdequate/mostly-adequate-guide/issues/608