search

MostlyAdequate / mostly-adequate-guide

Mostly adequate guide to FP (in javascript)
Other
23.39k stars 1.86k forks source link

Ch06: Fix link to script source #644

Closed timciep closed 10 months ago

timciep commented 10 months ago

Fix link to script source, which was not working on the GitBook site, by using the absolute GitHub URL.

ferllop commented 10 months ago

First of all excuse me if this not the proper place (or way) to communicate this..

This change modifying the include path of an exercise on chapter 6 now breaks the include when generating pdf and epub files and also when running gitbook on my local. The previous version was working ok for me in pdf, epub and gitbook.

Also note that in the public gitbook version of the book, the link is pointing to "mostly-adequate" repository instead of "mostlyadequate" (note the dash). I don't know how public gitbook is managed and from where came that "extra dash" but this dash seems to be the real error, not that the relative path was not working.

Maybe the solution is to revert this pull request and to update the public version with a corrected relative link and additionally show chapter 13 as well.

Greetings!