search

MostroP2P / mostro

Lightning Network peer-to-peer exchange platform on Nostr
https://mostro.network
MIT License
191 stars 32 forks source link

Simple idea for cancel take #331

Closed arkanoider closed 4 months ago

arkanoider commented 4 months ago

Hi @grunch,

a simple idea for #314.

Just adding some checks inside cancel.rs could lead to rewind to pending state the taken order imo.

Let me know your thoughts.

In this way cancel command would cancel a take too.

arkanoider commented 4 months ago

It only allows to cancel a take of buy order, but not a take of a sell order. Even though it cancels the take of buy order, it sends the message Not Allowed to the taker when cancell it.

Thanks for the tests @Catrya ! Probably i did some typo logic should in the same way, will check. Message can be changed, no issue.

arkanoider commented 4 months ago

Closing this. Not the right way to do cancel take.

arkanoider commented 4 months ago

Reopened PR - fixed.