MostroP2P / mostro

Lightning Network peer-to-peer exchange platform on Nostr
https://mostro.network
MIT License
191 stars 32 forks source link

Docs/improve readme #370

Closed jgmontoya closed 1 month ago

jgmontoya commented 1 month ago

Hi all 👋 !

Very minor improvements to the docs, let me know if you'd like the changes to be squashed unto a single commit.

jgmontoya commented 1 month ago

thank you for take your time doing this better formatting, great job, there is only one thing that I consider we should keep as it was before, please put hold back instead hodl 😃

Aren't they actually called hodl invoices? (e.g. https://lightningwiki.net/index.php/HODL_Invoice)

grunch commented 1 month ago

thank you for take your time doing this better formatting, great job, there is only one thing that I consider we should keep as it was before, please put hold back instead hodl 😃

Aren't they actually called hodl invoices? (e.g. https://lightningwiki.net/index.php/HODL_Invoice)

no, they are not

jgmontoya commented 1 month ago

thank you for take your time doing this better formatting, great job, there is only one thing that I consider we should keep as it was before, please put hold back instead hodl 😃

Aren't they actually called hodl invoices? (e.g. https://lightningwiki.net/index.php/HODL_Invoice)

no, they are not

My bad, I was mistaken:

I'll update the PR!

grunch commented 1 month ago

thank you for take your time doing this better formatting, great job, there is only one thing that I consider we should keep as it was before, please put hold back instead hodl 😃

Aren't they actually called hodl invoices? (e.g. https://lightningwiki.net/index.php/HODL_Invoice)

no, they are not

My bad, I was mistaken:

* https://lightning.engineering/api-docs/api/lnd/invoices/add-hold-invoice/index.html

* https://www.voltage.cloud/blog/understanding-hold-invoices-on-the-lightning-network

* https://buildonln.com/advanced/hold_invoices.html

* https://bitcoinops.org/en/topics/hold-invoices/

I'll update the PR!

great, thank you