Dispute readability

[arkanoider]

@grunch

playing a bit with some refactoring insipired a bit by cursorAI, he did quite well in App.rs imo and I tried to chunck big functions in dispute.rs to start.

Take a look with a grain of saly, just compiled not tested.

Summary by CodeRabbit

• New Features
  • Introduced new functions for improved message handling and dispute event publishing.
  • Added enhanced logging for error handling and action processing.
• Bug Fixes
  • Updated message creation for disputes and actions to improve clarity and maintainability.
• Refactor
  • Streamlined action handling processes, reducing redundancy and improving code organization.
  • Improved error handling and logging mechanisms across various functions.

[coderabbitai[bot]]

Walkthrough

The pull request introduces several modifications across multiple files to enhance action handling and logging within the application. Key changes include the addition of new helper functions for logging and processing message actions, as well as updates to existing functions to streamline the handling of parameters, particularly the request_id. The changes improve code organization and maintainability while ensuring that core functionalities remain intact.

Changes

File	Change Summary
src/app.rs	- Added fn warning_msg(action: &Action, e: anyhow::Error) - Added async fn handle_message_action(...) - Updated pub async fn run(...) to utilize the new action handling function and improved logging with tracing.
src/app/admin_take_dispute.rs	- Modified admin_take_dispute_action to pass None for request_id in messages to buyer and seller.
src/app/cancel.rs	- Simplified cancel_action, cancel_add_invoice, and cancel_pay_hold_invoice by removing redundant message sending lines while retaining cancellation logic.
src/app/dispute.rs	- Added async fn publish_dispute_event(...) - Added fn get_counterpart_info(...) - Updated async fn get_valid_order(...) to encapsulate order validation logic and improved error handling in dispute_action.
src/app/fiat_sent.rs	- Modified fiat_sent_action to pass None for request_id in seller's notification message.

Possibly related PRs

• #376: Involves the addition of a request_id parameter to several action functions, relevant to the main PR's improvements.
• #386: Modifies the run function to remove the request_id parameter from the call to take_buy_action, aligning with the main PR's focus.
• #387: Discusses the removal of request_id in various contexts, directly related to the main PR's handling of action parameters.
• #388: Involves removing the request_id from messages in the admin_take_dispute_action function, relevant to the main PR's modifications.

Suggested reviewers

• grunch

Poem

🐇 In the code where actions play,
A rabbit hops and clears the way.
With warnings logged and messages bright,
The flow is smooth, the code feels right.
No more clutter, just clarity's cheer,
Hopping along, the changes are here! 🌟

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

- [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)

🪧 Tips

### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit , please review it.` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (Invoked using PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. ### Other keywords and placeholders - Add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. - Add `@coderabbitai summary` to generate the high-level summary at a specific location in the PR description. - Add `@coderabbitai` anywhere in the PR title to generate the title automatically. ### CodeRabbit Configuration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](http://discord.gg/coderabbit) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.

[grunch]

Hey buddy tests are failing

[arkanoider]

Yep! Too many rabbit advices...will fix!

[arkanoider]

let's see now...