search

MotionDogs / Lenzhound-dev-pre-release

All active work now moved to Lenzhound-1.x repository. This repo will no longer be maintained.
GNU General Public License v3.0
0 stars 0 forks source link

Encoder velocity setting does not seem to be working anymore #20

Closed jacobbenlewis closed 10 years ago

jacobbenlewis commented 10 years ago

With the latest batch of changes the encoder speed control in play back mode no longer seems to work. Leaving it at 50% and moving between two saved positions sometimes moves at 50% and sometimes moves fast. Putting it down to 1% it seems to always run fast.

squarewave commented 10 years ago

Yeah @davidsthayer and I just noticed this. It's a bug with my latest commit - looking into it now.

squarewave commented 10 years ago

I've been banging my head against this a lot and it's giving me a lot of headaches. Honestly right now I feel like doing more work on the stepping algorithm without unit tests is a really bad decision, and we should either revert the commit addressing issue #20 or we should just revert the fix to #13 and remove support (temporarily) for anything other than 8th steps.

I still haven't seen with my own eyes that full steps give much more torque. I don't think it makes sense to have an option there that as far as we've observed just amounts to "make the damn thing louder," especially when it is creating this many headaches.

@davidsthayer, thoughts?

davidsthayer commented 10 years ago

Welllll.... right now, both of those look pretty good compared to what we've got! I do believe that full steps have more torque and we could try to set something up to test that - apart from current issues. I totally agree with unit tests. We can get everyone together for another power session. Yes? @jacobbenlewis ?

jacobbenlewis commented 10 years ago

Starting up unit tests couldn't be a bad thing.

This is your judgment call but if you are ready to ship hardware wise I would roll back whatever changes are causing the problems even if it means only working in 1/8th steps for now. I'm really anxious to get this in the hands of the users and let them tell us what they want.

I'm good for a meeting Thursday lunch, or sometime next week - out of town for the weekend. Could possibly do a late night this week too if you wanted.

davidsthayer commented 10 years ago

Okay, Doug can't do lunch. How about tomorrow (Thursday) evening?

jacobbenlewis commented 10 years ago

Sounds good. I can get there by about 8pm.

davidsthayer commented 10 years ago

So far no changes here correct? We're pulling resolution off the console. But is anything being done to wring through to playback speed?

davidsthayer commented 10 years ago

Playback speed seems whacked out again. Jumping randomly, with each button push, between what the encoder position says and some completely other (full?) speed. Didn't notice this over the weekend at all. We also saw this behavior at or meeting last Thursday.

davidsthayer commented 10 years ago

Suweet! :)