search

Motiva-AI / clj-sqs-extended

Client library for AWS SQS with support for large messages, up to 2GB. This is a Clojure wrapper for https://github.com/awslabs/amazon-sqs-java-extended-client-lib
MIT License
3 stars 0 forks source link

Switch project configuration to Leiningen #8

Closed ghost closed 4 years ago

ghost commented 4 years ago

It has just too many advantages so let's go with this.

ghost commented 4 years ago

I actually haven't triped deps yet. Could you list a couple advantages of Lein in this PR's comment to educate me please?

OK, the original PR comment was a little misleading I guess. I basically was looking at the things leiningen provided at the former sqs-utils and especially the packaging and test features made me consider this switch. It also still has better support with most development tools (editors/IDEs etc.) allowing a smoother/better out-of-the box experience.

I still like the deps.edn alternative because its so lean and can be custom-tailored exaxtly to your needs, but that takes time and effort. Maybe we can provide it later once the project reaches some sort of production/release state.

Quantisan commented 4 years ago

@daisybytes got it. LGTM. we don't need a 2nd review for a one-line change. you can merge this.