Mottie / Keyboard

Virtual Keyboard using jQuery ~
http://mottie.github.io/Keyboard/
Other
1.78k stars 723 forks source link

New setting "closeByClickEvent" implemented #476

Closed SeeeD closed 8 years ago

SeeeD commented 8 years ago

The new setting "closeByClickEvent" should prevent closing the keyboard on "touchstart" and "mousedown". This will allow the user to scroll the user during the keyboard is open.

Mottie commented 8 years ago

Hi @SeeeD!

Hmm, I was going to say that the userClosed option should do the same thing as this and point to the documentation, but it appears I never added it to the docs!

Please try the demo mentioned here: https://github.com/Mottie/Keyboard/issues/415#issuecomment-174198661

If that behaves the same as this option, please let me know.

SeeeD commented 8 years ago

Hi @Mottie,

thanks for you reply. I will have a look if this option will do the trick. :+1:

Mottie commented 8 years ago

Thanks! And I just finished adding the option to the docs: https://github.com/Mottie/Keyboard/wiki/Usability#userclosed

SeeeD commented 8 years ago

Hi @Mottie, this does not work for me. :( If I am testing the jsfiddle linked in #415 I will get the same issue. Clicking outside should close the keyboard, but scrolling should be possible too on touch mode (I am using this keyboard on a touch-device without built in keyboard).

Edit: I am not getting the same issue, sorry. If I am clicking outside the keyboard should close, but it should not close if I am scrolling with my fingers. :) Do you know how I mean?

Mottie commented 8 years ago

Hmm, ok. I'll look into this when I get some time later today.

Mottie commented 8 years ago

Ok, I'll go ahead and add this option. Thanks!