search

Mottie / Keyboard

Virtual Keyboard using jQuery ~
http://mottie.github.io/Keyboard/
Other
1.78k stars 723 forks source link

Hidden Event fires modal hidden event #629

Closed obermillerk closed 6 years ago

obermillerk commented 6 years ago

I know that you do not control how jQuery handles namespaces, but firing the hidden event on an input in a bootstrap modal when hiding the keyboard will activate any hidden.bs.modal listeners on the modal itself unless another listener is registered for the input element that stops propagation or you filter by the event namespace in the hidden.bs.modal listener. My proposition would be to change the name of this hidden event to something like keyboardHidden so that it does not conflict with other hidden events like this.

Obviously it's up to you, just wanted to suggest this/bring it to your attention in case you weren't aware of this conflict.

obermillerk commented 6 years ago

I apologize, I see now that there is a way to change this event name so it will not conflict. I still would rather the default be something different, but it's nice that I am able to change it.