search

Mottie / tablesorter

Github fork of Christian Bach's tablesorter plugin + awesomeness ~
https://mottie.github.io/tablesorter/docs/
2.61k stars 754 forks source link

Issue with columnSelector and new hasSpan #1810

Open TheSin- opened 2 years ago

TheSin- commented 2 years ago

The span detection code has broken old behaviour.

I haven't had time to look into it but we need a class to ignore the hasSpan as if you set a footer to the entire table, it is hidden is any one col is hidden. This should not be the case, or at least the behaviour has changed so we need a class like nohide or something to counter this breakage.

I use the footer to timestamp the data, if it's no in the print outs I can't help my users as I'm not sure when it was generated.

Mottie commented 2 years ago

Hey @TheSin-!

Can you share some example HTML? I haven't looked at this code in a while and it'd be nice to have an example.

TheSin- commented 2 years ago

I was going to just tell you to add

<tfoot><tr><td colspan="7">TIMESTAMP</td></tr></tfoot>

to the Bootstrap Popover example table at https://mottie.github.io/tablesorter/docs/example-widget-column-selector.html but I can't get the column selector to show up ;)

but if that was fixed just add that tfoot to the table then hide any single col and all of the footer is gone. That wasn't the case before, as long as it still fit. I'd like to be able to do something like

<tfoot><tr><td class="nohide" colspan="7">TIMESTAMP</td></tr></tfoot>

or something to stop the hasSpan class from being added so it doesn't hide the entire row when one col is hidden.