search

Mottl / lightgbm3-rs

LightGBM Rust library
MIT License
11 stars 6 forks source link

Re-export DType to the public interface ... #7

Closed milenkovicm closed 2 months ago

milenkovicm commented 2 months ago

... as it could be used to restrict other types

like:

<I as ArrowPrimitiveType>::Native: DType,

I see no alternatives to exposing this trait.

Mottl commented 2 months ago

Yes, that's great! But you need to make the DType sealed before exposing it, because LightGBM can only work with C_API_DTYPE_FLOAT32 and C_API_DTYPE_FLOAT64. Can you add this as well?

milenkovicm commented 2 months ago

No problem, added

milenkovicm commented 2 months ago

thanks a lot @Mottl do you plan cutting release any time soon ?

Mottl commented 2 months ago

Marko, sorry, too little new features yet :) If you want something more to add, I appreciate this 👍

milenkovicm commented 2 months ago

ok no problem @Mottl

Mottl commented 2 months ago

@milenkovicm, check for 1.0.4 on crates.io

milenkovicm commented 2 months ago

thanks you very much @Mottl