search

Moulberry / NotEnoughUpdates

http://moulberry.github.io/projects
GNU Lesser General Public License v3.0
469 stars 58 forks source link

Code cleanup #203

Closed gsquaredxc closed 2 years ago

gsquaredxc commented 3 years ago

My attempt at cleaning up some of the things inside the NEU codebase, feel free to cherry pick my changes. The primary goal is to improve readability while keeping performance in mind.

gsquaredxc commented 3 years ago

Might have gone a little overboard on my first PR to this repo, however these changes are just mainly internal and should only affect the readability of the code, as was the goal initially. It likely will not affect performance at all, however feel free to test for that.

IRONM00N commented 3 years ago

Moulberry doesn't like it when you add spaces after his if statements 😞

gsquaredxc commented 3 years ago

Should moulberry not like the last commit, it is always possible to cherry-pick that commit out, which will still help with readability but doesn't have the style stuff.

afkvido commented 2 years ago

@gsquaredxc Why'd you close this? It's a good pull request.