Moulberry / NotEnoughUpdates

http://moulberry.github.io/projects
GNU Lesser General Public License v3.0
469 stars 58 forks source link

Config option for farming overlay timeframe #209

Open Nubebuster opened 3 years ago

Nubebuster commented 3 years ago

In the video I provided you can see that it's hard to determine which crop speed I am getting. The range is between 4800 and 5200 when I am consistently breaking cocoa. Thats a pretty broad range.

My suggestion is to add a slider configuration option to the farming skill overlay where you can change the timeframe that is used in calculating xp/hr, crops/m etc. This would also make me able to determine crop speed including time where I am switching cocoa lanes.

Thanks in advance!

https://www.youtube.com/watch?v=S_BATRwRY3g

Nubebuster commented 3 years ago

This would involve the following lines:

Change the '4' to 'slidervalue + 1' Change the '>= 4' to '> slidervalue' https://github.com/Moulberry/NotEnoughUpdates/blob/ff2829153c14e0f7ca655bfd4ef64bffae3212b2/src/main/java/io/github/moulberry/notenoughupdates/overlays/FarmingOverlay.java#L139

Change the '/ 3f' to '/ (float) slidervalue' https://github.com/Moulberry/NotEnoughUpdates/blob/ff2829153c14e0f7ca655bfd4ef64bffae3212b2/src/main/java/io/github/moulberry/notenoughupdates/overlays/FarmingOverlay.java#L151

Nubebuster commented 3 years ago

On top of that, I would like to add that the crops per minute counter is overall very inaccurate currently. I just did a farming contest and got 106k cocoa in 20 minutes. That comes out to be 5300 crops/m. Howerver, the tracker has shown about 4000-4500 mostly. Here and there for a split second it would max out on 5200. But in any case even the max that the overlay counter has shown was still less than the actual rate.