search

MountainRange / MULE

OSS Mule, Built To New Heights :sunrise_over_mountains:
GNU General Public License v3.0
5 stars 0 forks source link

Cosmetic improvements to GameManager #36

Closed strburst closed 9 years ago

strburst commented 9 years ago

I've made a bunch of cosmetic improvements to GameManager and Shop. I've also outsourced gambling computations from GameManager to Shop, and added a couple tests.

I haven't yet touched the control flow in GameManager, but to prevent merge conflicts, I'm sending in a pull now. This branch is based on changes introduced in jay-tests and demo, so I'd recommend merging those too.

jgkamat commented 9 years ago

I'll look at this tomorrow I think, I'm kind of busy today... If someone else looks at it and says :+1: then it should be good.

strburst commented 9 years ago

I figured out how to get a fairly clean diff (excluding the changes in other branches): consult the diffs https://github.com/MountainRange/MULE/commit/da419f1aea01c08ec0e087da188e5ecd72366516 and https://github.com/MountainRange/MULE/compare/9861020...8111bcf.

jgkamat commented 9 years ago

:+1: This all looks good to me!