search

MountainRange / MULE

OSS Mule, Built To New Heights :sunrise_over_mountains:
GNU General Public License v3.0
5 stars 1 forks source link

Fix some Intellij warnings #59

Closed strburst closed 8 years ago

strburst commented 8 years ago

I did the same thing as I did for #54, but this time with Intellij's code analyzer (fixing the sensible/easy to fix warnings). Same reasoning as #54; we might be able to reduce the amount of justification we have to do to our TA today.

There are now 533 Intellij warnings, down from around 600. This pull mostly fixes spelling errors, makes various properties final, cleans out unused imports, and makes every file have a brief class-level Javadoc comment.

Also, @jgkamat, would it be possible to make get in Grid no longer deprecated? We are using it a lot, so we're getting lots of deprecation warnings.

jgkamat commented 8 years ago

LGTM, :+1:

jgkamat commented 8 years ago

Oh yah, you can de-depricate get. We were supposed to merge that when we made the serial upgrades.

strburst commented 8 years ago

I un-deprecated get and fixed the unchecked assignment warning in PlayController. I'll merge if there are no objections.