search

MousaZeidBaker / aws-lambda-typing

Python type hints for AWS Lambda
MIT License
106 stars 19 forks source link

Enrich and fix the IAM policy type #67

Closed YonatanGreenfeld closed 2 years ago

YonatanGreenfeld commented 2 years ago

Enrich the documentation, and elaborate the Principal type. Fix the usage of Optional as a not required key indicator and replace it with typed dict inheritance as specified in PEP-589.

fixes #66

MousaZeidBaker commented 2 years ago

Thanks for your contribution @YonatanGreenfeld. It's great you are fixing the misuse of optional, I've used it wrongly in some places in this project.

Regarding the doc appearance, adding dashes to urls results in linting error E501 line too long. Also I think its a bit overkill and noisy to add a url FOR EACH of the attributes, don't you think its enough to reference the base class?

YonatanGreenfeld commented 2 years ago

@MousaZeidBaker No problem, I'll reduce the noise of the docstrings