search

Mouse-Imaging-Centre / RMINC

Statistics for MINC volumes: A library to integrate voxel-based statistics for MINC volumes into the R environment. Supports getting and writing of MINC volumes, running voxel-wise linear models, correlations, etc.; correcting for multiple comparisons using the False Discovery Rate, and more. With contributions from Jason Lerch, Chris Hammill, Jim Nikelski and Matthijs van Eede. Some additional information can be found here:
https://mouse-imaging-centre.github.io/RMINC
Other
22 stars 17 forks source link

mincLmer accepts wrong parallel specification, happily goes on #215

Open gdevenyi opened 6 years ago

gdevenyi commented 6 years ago

Accidentally, did c("parallel",12) instead of c("local",12) and got a TORQUE job submission.

Should error out instead.

cfhammill commented 6 years ago

Hmmm I dunno, it's reasonably well documented that anything not "local" means ship to batchtools. But maybe I should just have NULL, ("local", N), or ("batchtools", N) as the only allowable options. It is a bit weird to pass in a two element character vector as a control list anyway but I don't really want to build around this now.

gdevenyi commented 6 years ago

I'm okay with changing to only those three options, since batchtools congfig is handled elsewhere.

gdevenyi commented 6 years ago

Come to think of it, I think I would actually prefer a global setting for the parallel backend, that way, I only need to change a script in one place to switch between local and cluster execution, instead of every instance of a parallel call. Although I guess that could be done with a variable passed to parallel...

cfhammill commented 6 years ago

That's already how it works, batchtools can run sequential and multicore you just need to set a config. It won't be quite as fast as the "local" but it's do-able