Replacing read.table and write.table for vertex functions with readr equivalent

Mouse-Imaging-Centre / RMINC

Statistics for MINC volumes: A library to integrate voxel-based statistics for MINC volumes into the R environment. Supports getting and writing of MINC volumes, running voxel-wise linear models, correlations, etc.; correcting for multiple comparisons using the False Discovery Rate, and more. With contributions from Jason Lerch, Chris Hammill, Jim Nikelski and Matthijs van Eede. Some additional information can be found here:

https://mouse-imaging-centre.github.io/RMINC

Other

23 stars 17 forks source link

Replacing read.table and write.table for vertex functions with readr equivalent #250

Closed vfonov closed 5 years ago

vfonov commented 5 years ago

I made a few changes:

switched to readr for vertex files input/output
switched from lsof to analyzing /proc/pid/fd
added ability to specify column for vertex stats
rerun roxygen to regenrate documentation
added tests to test that new reader works as expected

cfhammill commented 5 years ago

This looks great. Thanks Vlad. Being able to read zipped vertex files is a big plus. Also thanks for fixing the configuration!

vfonov commented 5 years ago

Hm, I also noticed that anatAnova anatLM tests fail ...

cfhammill commented 5 years ago

That I think is likely a change from our end. I'll investigate next week

On Fri, Jan 18, 2019, 5:01 PM Vladimir S. FONOV <notifications@github.com wrote:

Hm, I also noticed that anatAnova anatLM tests fail ...

— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub https://github.com/Mouse-Imaging-Centre/RMINC/pull/250#issuecomment-455701935, or mute the thread https://github.com/notifications/unsubscribe-auth/AHHwHvSCFbpkwlw00MPiCijUkXHJQ0cyks5vEkQrgaJpZM4aG1xY .

cfhammill commented 5 years ago

Hey @vfonov, our CI builds are failing with a cmake error. Any chance you can take a quick look:

https://travis-ci.org/Mouse-Imaging-Centre/RMINC/jobs/501684569#L6316

EDIT: I think I might have traced the problem. We might be ok.