search

Mouse-Imaging-Centre / RMINC

Statistics for MINC volumes: A library to integrate voxel-based statistics for MINC volumes into the R environment. Supports getting and writing of MINC volumes, running voxel-wise linear models, correlations, etc.; correcting for multiple comparisons using the False Discovery Rate, and more. With contributions from Jason Lerch, Chris Hammill, Jim Nikelski and Matthijs van Eede. Some additional information can be found here:
https://mouse-imaging-centre.github.io/RMINC
Other
22 stars 17 forks source link

mincTFCE doesn't make any attempt to use parallel option for the TFCE invocation #252

Open gdevenyi opened 5 years ago

gdevenyi commented 5 years ago

I expected mincTFCE parallel options to parallelize the TFCE call, however it appears parallel doesn't kick in until the mincRandomize calls.

cfhammill commented 5 years ago

TFCE isn't embarrassingly parallel, I didn't bother making the single invocation parallel, especially given it's usually run with permutation intervals. Parallelizing the core algorithm wouldn't be high on my list of things to do, it's pretty fast already. Or am I misunderstanding?

gdevenyi commented 5 years ago

It could at least run parallel over the mincSingleDim columns, I think that's what I mean?

cfhammill commented 5 years ago

It could be worthwhile for multDim's I think.

gdevenyi commented 5 years ago

Yes, I think that's what I mean :+1: