search

Mouse-Imaging-Centre / RMINC

Statistics for MINC volumes: A library to integrate voxel-based statistics for MINC volumes into the R environment. Supports getting and writing of MINC volumes, running voxel-wise linear models, correlations, etc.; correcting for multiple comparisons using the False Discovery Rate, and more. With contributions from Jason Lerch, Chris Hammill, Jim Nikelski and Matthijs van Eede. Some additional information can be found here:
https://mouse-imaging-centre.github.io/RMINC
Other
23 stars 17 forks source link

Update to develop branch of libminc #284

Closed gdevenyi closed 3 years ago

gdevenyi commented 4 years ago

Related to #283

Tests fine by running the model from getRMINCTestData()

cfhammill commented 4 years ago

So develop is the the master branch?

gdevenyi commented 4 years ago

minc-toolkit-v2 releases against hashes on the develop tree: https://github.com/BIC-MNI/minc-toolkit-v2/tree/release-1.9.17 -> https://github.com/BIC-MNI/libminc/tree/bcbccf97ddb5f483277cc701e33fd93803674597

That commit isn't on master: https://github.com/BIC-MNI/libminc/commits/master but its on develop: https://github.com/BIC-MNI/libminc/commits/develop

cfhammill commented 4 years ago

I'm a bit uncomfortable using develop. Any idea if we could just checkout specific commits that correspond to toolkit releases?

gdevenyi commented 4 years ago

Much better idea, I have now stamped in the 1.9.17 hash version instead.

bcdarwin commented 3 years ago

Updated to newer libminc branch to get the fix for #41/#281.