search

Mouse-Imaging-Centre / RMINC

Statistics for MINC volumes: A library to integrate voxel-based statistics for MINC volumes into the R environment. Supports getting and writing of MINC volumes, running voxel-wise linear models, correlations, etc.; correcting for multiple comparisons using the False Discovery Rate, and more. With contributions from Jason Lerch, Chris Hammill, Jim Nikelski and Matthijs van Eede. Some additional information can be found here:
https://mouse-imaging-centre.github.io/RMINC
Other
22 stars 17 forks source link

Major fix for compatibility with R>=4.3.0 #315

Closed yohanyee closed 4 months ago

yohanyee commented 1 year ago

Fixes the issue caused by hidden length arguments in R>=4.3.0, and addresses issue #314 . Some other minor edits include:

Successfully built with no failing tests on:

  1. R=4.3.0, x86_64-pc-linux-gnu (64-bit), Manjaro Linux
  2. R=3.6.3, x86_64-pc-linux-gnu (64-bit), Ubuntu 18.04.6 LTS
FatemahSakr commented 1 year ago

We have tried this fix and we got this error, We tried this (export LDFLAGS="$LDFLAGS -L$(brew --prefix zlib)/lib") also before opening R in terminal MacOS Monterey 12.6.7, R version 4.3.1

** building package indices
** testing if installed package can be loaded from temporary location
Error: package or namespace load failed for ‘RMINC’ in dyn.load(file, DLLpath = DLLpath, ...):
 unable to load shared object '/Library/Frameworks/R.framework/Versions/4.3-x86_64/Resources/library/00LOCK-RMINC-master-2/00new/RMINC/libs/RMINC.so':
  dlopen(/Library/Frameworks/R.framework/Versions/4.3-x86_64/Resources/library/00LOCK-RMINC-master-2/00new/RMINC/libs/RMINC.so, 0x0006): Library not loaded: 'libz.1.dylib'
  Referenced from: '/Library/Frameworks/R.framework/Versions/4.3-x86_64/Resources/library/00LOCK-RMINC-master-2/00new/RMINC/libs/RMINC.so'
  Reason: tried: 'libz.1.dylib' (no such file), '/Library/Frameworks/R.framework/Resources/lib/libz.1.dylib' (no such file), '/Library/Java/JavaVirtualMachines/jdk-11.0.18+10/Contents/Home/lib/server/libz.1.dylib' (no such file), '/Users/fatemahsakr/Downloads/RMINC-master-2/libz.1.dylib' (no such file), '/Library/Frameworks/R.framework/Resources/lib/libz.1.dylib' (no such file), '/Library/Java/JavaVirtualMachines/jdk-11.0.18+10/Contents/Home/lib/server/libz.1.dylib' (no such file)
Error: loading failed
Execution halted
ERROR: loading failed
* removing ‘/Library/Frameworks/R.framework/Versions/4.3-x86_64/Resources/library/RMINC’
gdevenyi commented 1 year ago

This looks unrelated and is an issue with your zlib library configuration

FatemahSakr commented 1 year ago

any idea how to fix zlib configuration ? I have tried to reinstall zlib using brew and the same error happened I even have tried to install RMINC while uninstalled zlib and the same error occur