Open gdevenyi opened 5 years ago
Any update on this? Running into this problem again.
Did you try the most recent develop (72b88fabc)?
I haven't tried any development versions and I wasn't aware that any changes had been made there.... I really wish github would give me some way to follow all commits on a project...
I'm sorry, I should have tagged the issue in the commit so you'd get a notification.
git-develop instead:
Traceback (most recent call last):
File "/opt/quarantine/minc-stuffs/git-develop/install/bin/rotational_minctracc.py", line 4, in <module>
__import__('pkg_resources').run_script('python-stuffs==0.1.23', 'rotational_minctracc.py')
File "/opt/quarantine/anaconda/5.1.0-python3/install/lib/python3.6/site-packages/pkg_resources/__init__.py", line 750, in run_script
self.require(requires)[0].run_script(script_name, ns)
File "/opt/quarantine/anaconda/5.1.0-python3/install/lib/python3.6/site-packages/pkg_resources/__init__.py", line 1534, in run_script
exec(script_code, namespace, namespace)
File "/opt/quarantine/minc-stuffs/git-develop/install/lib/python3.6/site-packages/python_stuffs-0.1.23-py3.6.egg/EGG-INFO/scripts/rotational_minctracc.py", line 436, in <module>
File "/opt/quarantine/minc-stuffs/git-develop/install/lib/python3.6/site-packages/python_stuffs-0.1.23-py3.6.egg/EGG-INFO/scripts/rotational_minctracc.py", line 427, in main
File "/opt/quarantine/minc-stuffs/git-develop/install/lib/python3.6/site-packages/python_stuffs-0.1.23-py3.6.egg/EGG-INFO/scripts/rotational_minctracc.py", line 274, in loop_rotations
TypeError: minctracc() got an unexpected keyword argument 'source_mask'
Added:
(f" -source_mask {source_mask} " if source_mask else "") +
and testing
oh and
minctracc(source, target, target_mask, source_mask, stepsize, wtranslations, simplex, use_lsq12_for_alignment):
Thanks. At some point when I was making these changes I realized @nzxwang was making a branch to generalize a bunch of settings including adding LSQ3/.../12 but I never got around to porting to that branch and for some reason left the changes in an inconsistent state.
However, I have neural brain segmentation now so hopefully brute-force rotations will soon be a thing of the past :)
Yup that fixes it up.
I can't help but feel that all my drilling down into bending registration tools to my will is going to be completely supplanted when I'm replaced by a neural network...