Mouse-Imaging-Centre / pydpiper

Python code for flexible pipeline control
Other
24 stars 10 forks source link

--resolution option should specify units #389

Open gdevenyi opened 5 years ago

gdevenyi commented 5 years ago

Current help doesn't mention the units of resolution

bcdarwin commented 5 years ago

I think everything's in mm as usual with minc tools.

We should also allow unit specifiers (vox, mm, um) and anisotropic resolutions (...x...x...) as ANTS tools do.

gdevenyi commented 5 years ago

Yeah, I figured it was, just noting that it probably should make that explicit. Also agree about the specifying all three resolutions :+1:

gdevenyi commented 5 years ago

Interestingly, the naming scheme of units applied to the file is in microns:

--resolution 0.1
pipeline-09-11-2018-at-14-11-12_reg_target_resampled/DSURQE_40micron_mask_100micron_resampled.mnc

100micron was added by the pipeline :)

bcdarwin commented 5 years ago

I won't say who was responsible for this!