twolevel_model_building.py's analysis.csv is broken

Mouse-Imaging-Centre / pydpiper

Python code for flexible pipeline control

Other

25 stars 10 forks source link

twolevel_model_building.py's analysis.csv is broken #440

Closed nzxwang closed 4 years ago

nzxwang commented 4 years ago

pd.concat doesn't properly merge the rows

https://github.com/Mouse-Imaging-Centre/pydpiper/blob/692b301a37723f2f5e2f6c98f60b0b2d20518ee2/pydpiper/pipelines/twolevel_model_building.py#L93

gdevenyi commented 4 years ago

https://github.com/Mouse-Imaging-Centre/pydpiper/issues/426

nzxwang commented 4 years ago

426

The issue you had was that analysis cannot merge with pd.concat([resampled, overall], axis=1). On the same line of code, the pd.concat() call is also wrong as it seems like resampled and overall do not maintain the order of the rows for some reason. This will be fixed for 2.0.14