Open psobolewskiPhD opened 2 years ago
Merging #33 (4e1ba9e) into main (6993bee) will decrease coverage by
0.34%
. The diff coverage is66.66%
.
@@ Coverage Diff @@
## main #33 +/- ##
==========================================
- Coverage 59.91% 59.57% -0.34%
==========================================
Files 3 3
Lines 232 235 +3
==========================================
+ Hits 139 140 +1
- Misses 93 95 +2
Impacted Files | Coverage Δ | |
---|---|---|
cellpose_napari/_dock_widget.py | 53.06% <66.66%> (-0.31%) |
:arrow_down: |
Test fails seem to be due to: https://github.com/napari/napari/issues/4747#issuecomment-1173469950 Maybe should just drop python 3.7 tests? and add linux?
Maybe should just drop python 3.7 tests? and add linux?
I can't see the direct connection to the importlib-metadata issue mentioned in that comment, but yes, if we're not explicitly pinning the napari dependency here to v0.14.4 (the last one to support 3.7), then i wouldn't expect any tests to work on 3.7. go ahead and drop
Hi @tlambert03 the python 3.7 tests are actually running in napari 0.4.14, but failing due to the importlib_metadata
issue. Anyhow, I will make a separate PR to try to try to drop 3.7 and add linux? I can probably copy-pasta from the cookiecutter 😉
Hmm, so now it's the same symptom as napari-serialcellpose
with macOS tests stalling:
https://github.com/guiwitz/napari-serialcellpose/pull/8
Not sure why simply adding progress=True
would do that...
Edit: The tests hang for my locally too, even though everything works when run in napari, so it's something related to qtbot/pytest-qt?
Grr, the hanging tests. Happens locally on my mac too -- but everything works when running in napari.
❯ pytest .
WARNING:root:openblas_set_num_threads not found
============================= test session starts ==============================
platform darwin -- Python 3.12.5, pytest-8.3.3, pluggy-1.5.0
PyQt5 5.15.11 -- Qt runtime 5.15.14 -- Qt compiled 5.15.14
rootdir: /Users/sobolp/Documents/dev/cellpose-napari
configfile: pyproject.toml
plugins: qt-4.4.0, napari-0.5.3, npe2-0.7.7, napari-plugin-engine-0.2.0
collected 3 items
tests/test_plugin.py ^C
Note: that control-C to interrupt wasn't successful, I had to kill the python processes -- there were 2.
This is a basic attempt at addressing https://github.com/MouseLand/cellpose-napari/issues/27 and showing some status/busy info the napari gui. The potentially long running tasks will now show an indicator that something is happening (the neato moving boxes in the lower right) Additionally, a notification is provided of the main tasks after click
run
: (down)loading models and running segmentationcc: @kandarpksk